This repository was archived by the owner on Oct 10, 2022. It is now read-only.
Group require() statements
#60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ehmicky
force-pushed
the
refactor/reorder-imports
branch
from
d755c78 to
0fd7f04
Compare
ehmicky
force-pushed
the
refactor/reorder-imports
branch
from
0fd7f04 to
d1035b4
Compare
ehmicky
requested review from
DavidWells and
keiko713
and removed request for
keiko713
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
- Summary
This ensures the
require()statements are grouped: first the core modules, then the node modules, then the local imports. This is much easier to browse code when imports/require are on top of the file and grouped.The
import/orderESLint rule is added so that the grouping happens automatically oneslint --fix, i.e. we don't need to think about it. This happens on save if your IDE supports (VSCode does).- Description for the changelog
Group
require()statements together.