fix(metriks): force empty Datadog sink hostname. Service name always in prefix. #140
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…in prefix. `Name` maps to Datadog sink `hostname` field. It is only used by armon/go-metrics lib and in a really non-well documented way. It is basically used for removing from the metrics key the hostname in favor of adding it (manually by the user) as tag. The library creator explains that it makes sense since Datadog is multidimensional so the tags should be used instead. See https://github.com/armon/go-metrics/blob/master/datadog/dogstatsd.go#L63-L82 We totally disagree.
smoya
added
the
type: chore
mheffner
suggested changes
Aug 5, 2020
There was a problem hiding this comment.
Yeah, I think that model is pretty common for single-dimension metric stores like Graphite.
This is an internal lib, so I'd say let's just remove it entirely to avoid confusion. Consumers can easily remove this single field from their configs when they update.
smoya
force-pushed
the
fix/datadogSinkMetricsHostname
branch
from
514ac11 to
6571bb7
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Nameconfig field maps to Datadog sinkhostnamefield. It is only used byarmon/go-metrics lib and in a really non-well documented way.
It is basically used for removing from the metrics key the hostname in
favor of adding it (manually by the user) as tag. The library creator
explains that it makes sense since Datadog is multidimensional so the
tags should be used instead.
This is causing issues like sending metrics without the expected prefix: I.e.:
my-app.hitshitsSee https://github.com/armon/go-metrics/blob/master/datadog/dogstatsd.go#L63-L82
We totally disagree.