add a LogErrToSpan #159
Merged
add a LogErrToSpan #159
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rybit
force-pushed
the
add-useful-tracing-func
branch
from
8279d9c to
8b6baf2
Compare
emilyzhang
added
the
type: feature
emilyzhang
approved these changes
Aug 20, 2020
| } | ||
|
|
||
| span.LogFields(otlog.String("event", "error"), otlog.Error(err)) | ||
| if sterr, ok := err.(stackTracer); ok { |
There was a problem hiding this comment.
out of curiosity what is happening here? O: it looks like you're checking to see whether you can create a new instance of the stacktracer interface from the error? (i've just never seen this err.(stackTracer) notation before)
There was a problem hiding this comment.
The general format is that you can do:
actualVersion, ifItMatches := someinterface.(whatYouWant)
This is using go's type inference to figure out if the error (which is an interface) passed in has that method.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This method is used in a few services and it is pretty useful. I think that it makes sense to import here. Also, anything to make opentracing more usable I'm all for