feat(kafka): add ConsumerFactory in order to align future developments #192
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smoya
added
enhancement
type: chore
smoya
commented
Oct 21, 2020
| @@ -62,7 +67,7 @@ type ConfluentConsumer struct { | |||
| // permission on the group coordinator for managing commits, so it needs a consumer group in the broker. | |||
| // In order to simplify, the default consumer group id is copied from the configured topic name, so make sure you have a | |||
| // policy that gives permission to such consumer group. | |||
| func NewDetachedConsumer(log logrus.FieldLogger, conf Config, opts ...ConfigOpt) (*ConfluentConsumer, error) { | |||
| func NewDetachedConsumer(log logrus.FieldLogger, conf Config, opts ...ConfigOpt) (Consumer, error) { | |||
There was a problem hiding this comment.
This bc is under control 👍
mrdg
approved these changes
Oct 22, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In an effort to help users of our Kafka lib with common use cases, this PR adds a Factory function type, which can be used for postponing the creation of a consumer on runtime. E.g. setting an initial offset that you don't know on boot time.
NewConsumerandNewDetachedConsumerimplements this already.