Skip to content

Fix tests around status code in tracing #201

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 15, 2020
Merged

Fix tests around status code in tracing #201

merged 1 commit into from
Dec 15, 2020

Conversation

mraerino
Copy link
Contributor

Follow-up for #197

@mraerino mraerino added the type: bug code to address defects in shipped code label Dec 15, 2020
@mraerino mraerino requested review from rybit and kschlarman December 15, 2020 15:51
@mraerino mraerino self-assigned this Dec 15, 2020
@mraerino mraerino requested a review from a team as a code owner December 15, 2020 15:51
This was referenced Dec 15, 2020
Merged
Merged
kschlarman
kschlarman approved these changes Dec 15, 2020
View reviewed changes
Copy link
Contributor

@kschlarman kschlarman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Or sorry! Thanks for fixing it.

@mraerino mraerino merged commit 74c4816 into master Dec 15, 2020
@mraerino mraerino deleted the fix/tracer-tests branch December 15, 2020 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kschlarman kschlarman kschlarman approved these changes

@rybit rybit Awaiting requested review from rybit

Assignees

@mraerino mraerino

Labels
type: bug code to address defects in shipped code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mraerino @kschlarman