Skip to content

feat: add AllEnabledFlagsUser to featureflag #242

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 30, 2021
Merged

feat: add AllEnabledFlagsUser to featureflag #242

merged 1 commit into from
Jun 30, 2021

Conversation

eduardoboucas
Copy link
Member

This PR adds a AllEnabledFlagsUser method to the featureflag package, which does the same as AllEnabledFlags but accepts a LD user as an argument. It follows the same pattern as Enabled/EnabledUser and Variation/VariationUser.

We'd need this in buildbot as part of https://github.com/netlify/buildbot/issues/1395.

@eduardoboucas eduardoboucas added the type: feature code contributing to the implementation of a feature and/or user facing functionality label Jun 29, 2021
@eduardoboucas eduardoboucas requested a review from vbrown608 June 29, 2021 23:00
@eduardoboucas eduardoboucas requested a review from a team as a code owner June 29, 2021 23:00
vbrown608
vbrown608 approved these changes Jun 29, 2021
View reviewed changes
Copy link
Contributor

@vbrown608 vbrown608 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💤

@eduardoboucas eduardoboucas merged commit caa948e into master Jun 30, 2021
@eduardoboucas eduardoboucas deleted the eb/allenabledflagsuser branch June 30, 2021 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
1 more reviewer

@vbrown608 vbrown608 vbrown608 approved these changes

Reviewers whose approvals may not affect merge requirements
Assignees
No one assigned
Labels
type: feature code contributing to the implementation of a feature and/or user facing functionality
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@eduardoboucas @vbrown608