Add service tag to metrics and traces #261
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheffner
added
the
type: feature
mheffner
commented
Nov 1, 2021
| bytes.Contains(buf, []byte(expectedMsg)) | ||
| require.True(t, readBytes > 0) | ||
|
|
||
| require.True(t, bytes.Equal(buf[0:readBytes], []byte(expectedMsg))) |
There was a problem hiding this comment.
This test wasn't actually comparing anything as the value of bytes.Contains was thrown out. Also, it was truncating the msg read based on the expectedMsg length, so we now read up to 512 bytes.
rybit
approved these changes
Nov 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds an automatic global
servicetag to metrics and traces set to the service name. This provides automatic correlation of metrics and traces emitted by a service so they can be found in DD.We only set this if the user hasn't already provided a global
servicetag.