Report gauges once per interval #274
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mheffner
added
the
type: chore
paulo
approved these changes
Dec 23, 2021
So gauges still report once per interval, so I don't know if reporting more frequently provides any additional granularity. If an application wants to record per-operation granular metrics it is probably better to use the Sample() or Distribution() type metrics. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Gauges report a snapshot value once per interval, so we don't need to report on every change. There shouldn't be a difference between reporting N times per interval and selecting one vs. simply reporting once. This should reduce overhead of reporting for gauges with high-frequency change rates.