feat!: remove packages that have been broken out #354
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rybit
commented
Oct 7, 2022
| @@ -0,0 +1,100 @@ | |||
| package mongoclient | |||
There was a problem hiding this comment.
this is stolen from go-http/ntls
rybit
changed the title
paulo
approved these changes
Oct 10, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGES:
metriks-> github.com/netlify/go-observabilitytracing-> github.com/netlify/go-observabilityutils-> github.com/netlify/go-utilstestutils-> github.com/netlify/go-test-utilsserver-> github.com/netlify/go-httprouter-> github.com/netlify/go-httpfeatureflag-> github.com/netlify/go-flagsnconf-> github.com/netlify/go-configThen in each service we'd be able to configure those utilities in the service to allow for independent versioning per service. No more huge upgrades!
I've copied the go-http/ntls structs to individual packages here so that they can be independently deprecated or ported. They're repeated files but I thought that better to be able to use the separately.
Note: these are all private packages, we need to make sure that you've got CI setup to access them properly
Examples: