[nats] Implement more auth methods #83
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rybit
reviewed
May 31, 2019
|
ready to review again @rybit. I had to split the key/cert and CA loading because with the new NATS auth methods, we need the CA but not the client certificate |
rybit
reviewed
Jun 4, 2019
rybit
reviewed
Jun 4, 2019
rybit
reviewed
Jun 4, 2019
rybit
approved these changes
Jun 4, 2019
|
@rybit can you do a final review? |
rybit
approved these changes
Jun 6, 2019
|
I verified this code also works with cachecontroller |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implement new auth methods for NATS:
More info: https://nats.io/documentation/server/gnatsd-authentication/
Requirement for: https://github.com/netlify/nats-streamer/pull/2