This repository was archived by the owner on Sep 12, 2019. It is now read-only.
Fix live tunnel port when proxyPort is taken #146
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When starting the proxy we first check if proxyPort is free and otherwise we pick a random free port. The live tunnel would always connect to the port specified in the settings, so in that case it would start serving the wrong dev server on the .live domain. This makes sure we pass on the new port to the live tunnel if changed
calavera
reviewed
Apr 19, 2019
| @@ -243,18 +241,18 @@ class DevCommand extends Command { | |||
| settings.functionsPort = functionsPort; | |||
| } | |||
|
|
|||
| const proxyUrl = await startProxy(settings, addonUrls); | |||
| let { url, port } = await startProxy(settings, addonUrls); | |||
| if (!url) { | |||
| url = proxyUrl; | |||
There was a problem hiding this comment.
this conditional is not necessary anymore, is it?
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When starting the proxy we first check if proxyPort is free and otherwise we pick a random free port.
The live tunnel would always connect to the port specified in the settings, so in that case it would
start serving the wrong dev server on the .live domain.
This makes sure we pass on the new port to the live tunnel if changed