Add WaitUntilDeployLive Go client method #262
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Deploy preview for open-api ready! Built with commit e2c70ae |
vbrown608
added
the
type: feature
vbrown608
force-pushed
the
261-wait-until-deploy-live
branch
from
41d2435 to
e2c70ae
Compare
Benaiah
approved these changes
Sep 30, 2020
|
Thanks for doing this PR! I agree that "live" is a good term to use in the name for this method, especially given the "Site is live" message. It's also much more specific than "ready", so it'll be clearer what it means when we use it elsewhere. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Unfortunately, this is really waiting until the deploy is in the
readystate, but we already have a public method calledWaitUntilDeployReadythat waits until the deploy isreadyorprepared(ie ready to start uploading files).I went with
WaitUntilDeployLivebecause it mirrors the "Site is live" message that appears in the deploy logs. Open to other suggestions.Closes #261
Part of https://github.com/netlify/pod-the-builder/issues/47