Skip to content

chore: Added hyperlink on logo #359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from Oct 13, 2021
Merged

chore: Added hyperlink on logo #359

merged 1 commit into from Oct 13, 2021

Conversation

fayasnoushad
Copy link
Contributor

Just added hyperlink on logo

Just added hyperlink on logo
@fayasnoushad fayasnoushad requested a review from a team as a code owner October 13, 2021 16:51
@netlify
Copy link

netlify bot commented Oct 13, 2021

✔️ Deploy Preview for open-api ready!

🔨 Explore the source changes: 9711061

🔍 Inspect the deploy log: https://app.netlify.com/sites/open-api/deploys/61670e9dfefba700073d3dfc

😎 Browse the preview: https://deploy-preview-359--open-api.netlify.app

mraerino
mraerino previously approved these changes Oct 13, 2021
Copy link
Contributor

@mraerino mraerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for your contribution!

Copy link
Contributor

@mraerino mraerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm, i don't see this working in the deploy preview: https://deploy-preview-359--open-api.netlify.app/

Looks like our custom template is overwriting this.
Did you test it before?

@mraerino mraerino dismissed their stale review October 13, 2021 16:55

Not working

@fayasnoushad
Copy link
Contributor Author

hmm, i don't see this working in the deploy preview: https://deploy-preview-359--open-api.netlify.app/

Looks like our custom template is overwriting this. Did you test it before?

Its added on README

Copy link
Contributor

@mraerino mraerino left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah right, sorry

@mraerino mraerino added the type: chore work needed to keep the product and development running smoothly label Oct 13, 2021
@mraerino mraerino changed the title Added hyperlink on logo chore: Added hyperlink on logo Oct 13, 2021
@mraerino mraerino merged commit a9ed74a into netlify:master Oct 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
type: chore work needed to keep the product and development running smoothly
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants