Skip to content

Conversation

msherif1234
Copy link
Contributor

@msherif1234 msherif1234 commented Sep 13, 2023

backport fix for #174

Signed-off-by: msherif1234 mmahmoud@redhat.com
(cherry picked from commit cca4aa3)

…etobserv#174)

Signed-off-by: msherif1234 <mmahmoud@redhat.com>
(cherry picked from commit cca4aa3)
@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 13, 2023

@msherif1234: This pull request references NETOBSERV-1240 which is a valid jira issue.

In response to this:

#174)

Signed-off-by: msherif1234 mmahmoud@redhat.com
(cherry picked from commit cca4aa3)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@codecov
Copy link

codecov bot commented Sep 13, 2023

Codecov Report

Patch coverage: 100.00% and project coverage change: +0.30% 🎉

Comparison is base (faf274e) 39.21% compared to head (a3bc0c9) 39.51%.

Additional details and impacted files
@@               Coverage Diff               @@
##           release-1.4     #176      +/-   ##
===============================================
+ Coverage        39.21%   39.51%   +0.30%     
===============================================
  Files               31       31              
  Lines             2382     2394      +12     
===============================================
+ Hits               934      946      +12     
  Misses            1391     1391              
  Partials            57       57              
Flag Coverage Δ
unittests 39.51% <100.00%> (+0.30%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files Changed Coverage Δ
pkg/flow/deduper.go 100.00% <100.00%> (ø)

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@openshift-ci-robot
Copy link
Collaborator

openshift-ci-robot commented Sep 13, 2023

@msherif1234: This pull request references NETOBSERV-1240 which is a valid jira issue.

In response to this:

backport fix for #174

Signed-off-by: msherif1234 mmahmoud@redhat.com
(cherry picked from commit cca4aa3)

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@jotak
Copy link
Member

jotak commented Sep 13, 2023

/approve

@openshift-ci
Copy link

openshift-ci bot commented Sep 13, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: jotak

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-robot openshift-merge-robot merged commit 4f4851d into netobserv:release-1.4 Sep 13, 2023
@msherif1234 msherif1234 deleted the bp_dns_fix branch September 13, 2023 14:36
@msherif1234 msherif1234 changed the title NETOBSERV-1240: prefer flows with DNS records when checking for DNS [backport] NETOBSERV-1240: prefer flows with DNS records when checking for DNS [1.4 backport] Sep 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants