-
Notifications
You must be signed in to change notification settings - Fork 4
NETOBSERV-2071 CLI 1.8 improvments #5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
🙈 The PR is closed and the preview is expired. |
to run the agents on the node with the `kubernetes.io/hostname:my-node` label. | ||
|
||
### eBPF Filters | ||
Agents recently introduced [the ability to filter](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/docs/flow_filtering.md) on IPs, Ports, Protocol, Action, TCPFlags, and more simultaneously. You can now apply these filters in the CLI as shown below: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe, to be done later, link to @msherif1234 's blog on filters when it ready
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Agents recently introduced [the ability to filter](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/docs/flow_filtering.md) on IPs, Ports, Protocol, Action, TCPFlags, and more simultaneously. You can now apply these filters in the CLI as shown below: | |
Agents recently introduced [the ability to filter](./2025-01-30-ebpf-flows-filtering.md) on IPs, Ports, Protocol, Action, TCPFlags, and more simultaneously. You can now apply these filters in the CLI as shown below: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice blog!
A few comments, nothing big, LGTM otherwise!
Co-authored-by: Joel Takvorian <joel.takvorian@homeblocks.net>
Co-authored-by: Joel Takvorian <joel.takvorian@homeblocks.net>
Co-authored-by: Joel Takvorian <joel.takvorian@homeblocks.net>
Co-authored-by: Joel Takvorian <joel.takvorian@homeblocks.net>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A handful of comments. Looking good. Globally, I wonder if you want to reconsider future tense, use of "will". Like maybe you can make more of those present tense?
Co-authored-by: Sara Thomas <sarthoma@redhat.com>
Co-authored-by: Sara Thomas <sarthoma@redhat.com>
Co-authored-by: Sara Thomas <sarthoma@redhat.com>
Co-authored-by: Sara Thomas <sarthoma@redhat.com>
Co-authored-by: Sara Thomas <sarthoma@redhat.com>
Sure, here we go: bffd144 |
1.8 blog article for CLI
See concrete scenarios in #6