Skip to content

Conversation

jpinsonneau
Copy link
Contributor

@jpinsonneau jpinsonneau commented Jan 23, 2025

1.8 blog article for CLI

See concrete scenarios in #6

Copy link

github-actions bot commented Jan 30, 2025

🙈 The PR is closed and the preview is expired.

to run the agents on the node with the `kubernetes.io/hostname:my-node` label.

### eBPF Filters
Agents recently introduced [the ability to filter](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/docs/flow_filtering.md) on IPs, Ports, Protocol, Action, TCPFlags, and more simultaneously. You can now apply these filters in the CLI as shown below:
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Maybe, to be done later, link to @msherif1234 's blog on filters when it ready

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Agents recently introduced [the ability to filter](https://github.com/netobserv/netobserv-ebpf-agent/blob/main/docs/flow_filtering.md) on IPs, Ports, Protocol, Action, TCPFlags, and more simultaneously. You can now apply these filters in the CLI as shown below:
Agents recently introduced [the ability to filter](./2025-01-30-ebpf-flows-filtering.md) on IPs, Ports, Protocol, Action, TCPFlags, and more simultaneously. You can now apply these filters in the CLI as shown below:

Copy link
Member

@jotak jotak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice blog!
A few comments, nothing big, LGTM otherwise!

jpinsonneau and others added 3 commits February 3, 2025 15:42
Co-authored-by: Joel Takvorian <joel.takvorian@homeblocks.net>
Co-authored-by: Joel Takvorian <joel.takvorian@homeblocks.net>
Co-authored-by: Joel Takvorian <joel.takvorian@homeblocks.net>
Copy link
Contributor

@skrthomas skrthomas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

A handful of comments. Looking good. Globally, I wonder if you want to reconsider future tense, use of "will". Like maybe you can make more of those present tense?

jpinsonneau and others added 6 commits February 4, 2025 17:19
Co-authored-by: Sara Thomas <sarthoma@redhat.com>
Co-authored-by: Sara Thomas <sarthoma@redhat.com>
Co-authored-by: Sara Thomas <sarthoma@redhat.com>
Co-authored-by: Sara Thomas <sarthoma@redhat.com>
Co-authored-by: Sara Thomas <sarthoma@redhat.com>
@jpinsonneau
Copy link
Contributor Author

A handful of comments. Looking good. Globally, I wonder if you want to reconsider future tense, use of "will". Like maybe you can make more of those present tense?

Sure, here we go: bffd144

@jotak jotak merged commit f2f1531 into netobserv:main Feb 11, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants