NETOBSERV-2009: network events to string #135
Conversation
|
New image: It will expire after two weeks. To use this build, update your commands using: USER=netobserv VERSION=95f3c17 make commands |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #135 +/- ##
==========================================
+ Coverage 23.53% 23.70% +0.17%
==========================================
Files 11 11
Lines 1330 1333 +3
==========================================
+ Hits 313 316 +3
Misses 1000 1000
Partials 17 17
Flags with carried forward coverage won't be shown. Click here to find out more.
|
|
/lgtm |
msherif1234
changed the title
|
@jotak: This pull request references NETOBSERV-2009 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
|
@jotak @msherif1234 I still don't see network events with the CLI image in this PR: 
for same flows I am able to see network events in console: @msherif1234 - does running cli as CLI |
|
@memodi it's not |
jotak
force-pushed
the
netevents-to-string
branch
from
0d630d9 to
5330730
Compare
jotak
force-pushed
the
netevents-to-string
branch
from
5330730 to
3090df5
Compare
|
New image: It will expire after two weeks. To use this build, update your commands using: USER=netobserv VERSION=eea11bd make commands |
|
For info I'll have to update this PR again after a change in ovnk-lib . Not a breaking change, but will improve how many dependencies are pulled. Needs a bump in agent too: netobserv/netobserv-ebpf-agent#564 |
|
Work as expected. Feel free to merge before or after the lib update 😉 Thanks @jotak |
|
New image: It will expire after two weeks. To use this build, update your commands using: USER=netobserv VERSION=4ac4561 make commands |
|
@jotak: This pull request references NETOBSERV-2009 which is a valid jira issue. Warning: The referenced jira issue has an invalid target version for the target branch this PR targets: expected the bug to target the "4.19.0" version, but no target version was set. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
update vendors
jotak
force-pushed
the
netevents-to-string
branch
from
e8475ec to
b7eb9a0
Compare
|
New changes are detected. LGTM label has been removed. |
|
/approve |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: jotak The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
I've only been able to test through unit tests, not in live (I have issues deploying the CLI which I must investigate )