Skip to content

Conversation

jpinsonneau
Copy link
Contributor

Description

Add kubectl support to commands. Example:

K8S_CLI_BIN=kubectl IMAGE_ORG=jpinsonn VERSION=dev make flows

will create kubectl commands and run flows using custom image.

Commands can still be run manually from ./commands/netobserv-XXX since scripts are detecting automatically which CLI is available (oc is favorite choice)

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

  • Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
  • Does this PR require product documentation?
    • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
  • Does this PR require a product release notes entry?
    • If so, fill in "Release Note Text" in the JIRA.
  • Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
    • If so, make sure it is described in the JIRA ticket.
  • QE requirements (check 1 from the list):
    • Standard QE validation, with pre-merge tests unless stated otherwise.
    • Regression tests only (e.g. refactoring with no user-facing change).
    • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

Comment on lines +5 to +8
labels:
app: netobserv
pod-security.kubernetes.io/enforce: privileged
pod-security.kubernetes.io/audit: privileged
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

☝️ kubectl can't manage pod-security at metadata level

@msherif1234
Copy link
Contributor

/lgtm

Copy link

codecov bot commented Apr 12, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 31.25%. Comparing base (f58b119) to head (62e0b8a).
Report is 14 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##            main      #26       +/-   ##
==========================================
+ Coverage   0.00%   31.25%   +31.25%     
==========================================
  Files          5        5               
  Lines        898      944       +46     
==========================================
+ Hits           0      295      +295     
+ Misses       898      629      -269     
- Partials       0       20       +20     
Flag Coverage Δ
unittests 31.25% <ø> (+31.25%) ⬆️

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

openshift-ci bot commented Apr 15, 2024

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-merge-bot openshift-merge-bot bot merged commit 551a15c into netobserv:main Apr 15, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants