-
Notifications
You must be signed in to change notification settings - Fork 15
[release-1.9] NETOBSERV-2366: use legacy attach mode #364
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[release-1.9] NETOBSERV-2366: use legacy attach mode #364
Conversation
@openshift-cherrypick-robot: Ignoring requests to cherry-pick non-bug issues: NETOBSERV-2366 In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
[APPROVALNOTIFIER] This PR is NOT APPROVED This pull-request has been approved by: The full list of commands accepted by this bot can be found here.
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Hi @openshift-cherrypick-robot. Thanks for your PR. I'm waiting for a netobserv member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
/ok-to-test |
New image: It will expire after two weeks. To use this build, update your commands using: USER=netobserv VERSION=5b67f22 make commands |
/lgtm |
/label qe-approved |
@openshift-cherrypick-robot: This pull request references NETOBSERV-2366 which is a valid jira issue. In response to this:
Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the openshift-eng/jira-lifecycle-plugin repository. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## release-1.9 #364 +/- ##
============================================
Coverage 22.83% 22.83%
============================================
Files 14 14
Lines 1454 1454
============================================
Hits 332 332
Misses 1099 1099
Partials 23 23
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
This is an automated cherry-pick of #363
/assign jotak