-
Notifications
You must be signed in to change notification settings - Fork 15
NETOBSERV-2262 Auto-detect feature that require privileged mode in CLI #374
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #374 +/- ##
=======================================
Coverage 17.20% 17.20%
=======================================
Files 15 15
Lines 2133 2133
=======================================
Hits 367 367
Misses 1740 1740
Partials 26 26
Flags with carried forward coverage won't be shown. Click here to find out more. 🚀 New features to boost your workflow:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
/lgtm
/ok-to-test |
New image: It will expire after two weeks. To use this build, update your commands using: USER=netobserv VERSION=9ef0808 make commands |
/label qe-approved |
/approve |
[APPROVALNOTIFIER] This PR is APPROVED Approval requirements bypassed by manually added approval. This pull-request has been approved by: memodi The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Description
Auto detect when privileged is needed and enable it.
Also expose a
--privileged
option in case we need to force it.Dependencies
n/a
Checklist
If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.