NETOBSERV-1693 Prompt for copying files on exit

[jpinsonneau]

Description

Ask for copy on exit

INFO[0034] Ctrl-C pressed, exiting program.             
kubernetes-admin
Copy the capture output locally ?y
Copying collector output files...

Cleaning up... namespace "netobserv-cli" deleted

INFO[0004] Ctrl-C pressed, exiting program.             
kubernetes-admin
Copy the capture output locally ?n
copy skipped

Cleaning up... namespace "netobserv-cli" deleted

The total capture size will be displayed in #59

Dependencies

n/a

Checklist

If you are not familiar with our processes or don't know what to answer in the list below, let us know in a comment: the maintainers will take care of that.

• Is this PR backed with a JIRA ticket? If so, make sure it is written as a title prefix (in general, PRs affecting the NetObserv/Network Observability product should be backed with a JIRA ticket - especially if they bring user facing changes).
• Does this PR require product documentation?
  • If so, make sure the JIRA epic is labelled with "documentation" and provides a description relevant for doc writers, such as use cases or scenarios. Any required step to activate or configure the feature should be documented there, such as new CRD knobs.
• Does this PR require a product release notes entry?
  • If so, fill in "Release Note Text" in the JIRA.
• Is there anything else the QE team should know before testing? E.g: configuration changes, environment setup, etc.
  • If so, make sure it is described in the JIRA ticket.
• QE requirements (check 1 from the list):
  • Standard QE validation, with pre-merge tests unless stated otherwise.
  • Regression tests only (e.g. refactoring with no user-facing change).
  • No QE (e.g. trivial change with high reviewer's confidence, or per agreement with the QE team).

[openshift-ci]

Skipping CI for Draft Pull Request.
If you want CI signal for your change, please convert it to an actual PR.
You can still manually trigger a test run with /test all

[codecov]

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 28.96%. Comparing base (cccd05d) to head (b015747).
Report is 1 commits behind head on main.

Additional details and impacted files

@@            Coverage Diff             @@
##             main      #60      +/-   ##
==========================================
- Coverage   28.99%   28.96%   -0.03%     
==========================================
  Files           8        8              
  Lines        1045     1046       +1     
==========================================
  Hits          303      303              
- Misses        720      721       +1     
  Partials       22       22              

Flag	Coverage Δ
unittests	28.96% <0.00%> (-0.03%)	⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

Files	Coverage Δ
e2e/common.go	0.00% <0.00%> (ø)

[msherif1234]

not sure why we need captureStarted since we are in cleanup path then captured should always been started no ?

[jpinsonneau]

if the script crash before running the pod, it will ask for copy whereas it can't so that's a safeguard

[msherif1234]

why did u drop exit 1 here ?

[jpinsonneau]

if the pods are not available, I want the script to crash here

[msherif1234]

/lgtm

[Amoghrd]

@jpinsonneau CLI can only be tested with a downstream build so you can go ahead and merge it and I can verify it with a downstream build

[jpinsonneau]

sure @Amoghrd, thanks for letting me know.

[openshift-ci]

[APPROVALNOTIFIER] This PR is APPROVED

Approval requirements bypassed by manually added approval.

This pull-request has been approved by:

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

• OWNERS

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment