Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

General error: 25 bind or column index out of range fix #46

Closed
wants to merge 1 commit into from

Conversation

@hubipe
Copy link
Contributor

hubipe commented Oct 5, 2016

When called SQLiteJournal::clean method with non-consequent integer keys, method execute had thrown exception General error: 25 bind or column index out of range.

@dg

This comment has been minimized.

Copy link
Member

dg commented Oct 5, 2016

I feel that there are other places in SQLiteStorage and SQLiteJournal that should be fixed. Maybe it would be better to fix it in Cache::clean() and Cache::completeDependencies().

@hubipe

This comment has been minimized.

Copy link
Contributor Author

hubipe commented Oct 5, 2016

All right, I have just changed the casting to array list in Cache. Unfortunately, there are three errors in tests, because when trying to write dependency as a string, it is converted to array list. Tests expects it to be string though, therefore it fails. I'm not sure, if this is a problem of tests or expected behaviour.

Wouldn't it be better then, to cast tags to array list inside SQLiteStorage and SQLiteJournal only?

@hubipe hubipe closed this Oct 5, 2016
@hubipe hubipe reopened this Oct 5, 2016
@dg

This comment has been minimized.

Copy link
Member

dg commented Oct 6, 2016

IMHO this is correct solution because storages currently rely on normalized dependencies. So it is only other normalization.
Thanks!

@dg dg closed this in 2c794dd Oct 6, 2016
dg added a commit that referenced this pull request Oct 6, 2016
dg added a commit that referenced this pull request Oct 6, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.