Skip to content

Conversation

milo
Copy link
Member

@milo milo commented Jan 9, 2023

I think pass dependencies as a 3rd Cache::load() argument have use cases, even it is not so lazy. For example, I already have data loader defined elsewhere:

$data = $cache->load('key', $client->getDataLoader(), [Cache::Expire => '10 minutes']);

# vs.

$data = $cache->load('key', function (&$dep) use ($client) {
    $dep[Cache::Expire => '10 minutes'];
    return ($client->getDataLoader())();
});

@dg
Copy link
Member

dg commented Jan 11, 2023

Thanks

@dg dg merged commit 44e813f into nette:master Jan 11, 2023
@milo
Copy link
Member Author

milo commented Jan 11, 2023

Thank you.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants