Skip to content

Conversation

dakorpar
Copy link

@dakorpar dakorpar commented Jan 5, 2020

Took me some time to get to that info and it's kinda basic info that a lot of people want to know

Took me some time to get to that info and it's kinda basic info that a lot of people want to know
@dg
Copy link
Member

dg commented Jan 5, 2020

Yeah, but I really don't want anyone to know it and use it :-)

@mabar
Copy link
Contributor

mabar commented Jan 5, 2020

Understandable in presenters, which have many dependencies by-design, but it's better to use constructor everywhere else.

@dakorpar
Copy link
Author

dakorpar commented Jan 5, 2020

Well I'm using it only in abstract classes, otherwise it's a big no, but still it's worth noting.
Presenters definitivelly need this, same as repositories, maybe some other layer as well depending on app structure. Using it in normal services is ofcours bad.

I do understand that having this in documentation could lead begginers to overuse this, so it's mayb better not to have it, but still you need it if you have repository layer or some other which would benefit from this...

@dg
Copy link
Member

dg commented Jan 5, 2020

Of course this should be in the documentation, but it belongs to the InjectExtension documentation. This should not be in the SearchExtension configuration description because for the vast majority of users this is irrelevant.

@dakorpar
Copy link
Author

dakorpar commented Jan 5, 2020

In programming and logic way I agree, but most of developers will look into search extension documentation to see how to do that...
However I agree and I'm closing this.

@dakorpar dakorpar closed this Jan 5, 2020
@dakorpar dakorpar deleted the patch-1 branch January 5, 2020 19:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants