ScriptUrl: Fix class extendability (issue #187) #188
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JanTvrdik
reviewed
Nov 15, 2020
| @@ -54,7 +54,8 @@ public function withPath(string $path, string $scriptPath = '') | |||
| { | |||
| $dolly = clone $this; | |||
| $dolly->scriptPath = $scriptPath; | |||
| return call_user_func([$dolly, 'parent::withPath'], $path); | |||
| $parent = \Closure::fromCallable([UrlImmutable::class, 'withPath'])->bindTo($dolly); | |||
| return $parent($path); | |||
There was a problem hiding this comment.
Closure::call() exists since PHP 7, so it should be possible to simplify this to
Closure::fromCallable([UrlImmutable::class, 'withPath'])->call($dolly, $path)There was a problem hiding this comment.
I tried it first. It works only for anonymous functions.
Cannot rebind scope of closure created by ReflectionFunctionAbstract::getClosure()
More info: https://bugs.php.net/bug.php?id=74558
|
Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
UrlScriptis not work correctly when is extended. The methodwithPath()is calling themself recursive in infinite loop and crash with error:The reason is the callback
parent::withPathincall_user_func()function is always called in top of descendants hierarchy context (see more at issue #187).PR is changing relative reference to parent class to absolute. Here is no able to use only
parentbecause method is called in another instance than$this(cloned one).Tests:
Resolve #187