Skip to content

Promoted Parameters don't have "readonly" when using Factory #158

@WalterWoshid

Description

@WalterWoshid

Version: 6.36.0

Bug Description

When using $method = (new Factory)->fromMethodReflection($refMethod); and printing the code with $method->__toString(); the readonly keyword is missing.

Steps To Reproduce

class Number
{
    public function __construct(public readonly int $value) {}
}

$reflectionClass = new \ReflectionClass(Number::class);
$reflectionMethod = $reflectionClass->getMethod('__construct');
$method = (new Factory)->fromMethodReflection($reflectionMethod);
$result = (string)$method;

Expected Behavior

Should include readonly

Possible Solution

Factory::fromParameterReflection():

public function fromParameterReflection(...): Parameter
{
    // ...
    
    if ($from->isPromoted()
        && PHP_VERSION_ID >= 80100
        && ($declaringClass = $from->getDeclaringClass())
        && $declaringClass->hasProperty($from->name)
        && ($property = $declaringClass->getProperty($from->name))
        && $property->isPromoted()
        && !(PHP_VERSION_ID >= 80200 && $from->getDeclaringClass()->isReadOnly())
    ) {
        $param->setReadOnly($property->isReadOnly());
    }

    // ...
}

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions