Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

improve parse code in Extractor #150

Merged
merged 1 commit into from Jan 17, 2024
Merged

improve parse code in Extractor #150

merged 1 commit into from Jan 17, 2024

Conversation

yoosefap
Copy link
Contributor

  • bug fix / new feature?
  • BC break? yes/no
  • doc PR: nette/docs#???

@dg
Copy link
Member

dg commented Jan 15, 2024

It should be compatible with version 4 too

@JanTvrdik
Copy link
Contributor

JanTvrdik commented Jan 16, 2024 •
edited

ParserFactory::createForNewestSupportedVersion was backported to PHP-Parser 4.18, so sth like ^4.18 || ^5.0 should work

@dg dg merged commit 821a89c into nette:master Jan 17, 2024
@dg
Copy link
Member

dg commented Jan 17, 2024

Thanks

dg pushed a commit that referenced this pull request Jan 17, 2024
@yoosefap @dg
Extractor: supports PHP-Parser 5.0 (#150)
7e6104e
dg pushed a commit that referenced this pull request Jan 17, 2024
@yoosefap @dg
Extractor: supports PHP-Parser 5.0 (#150)
ac62671
dg pushed a commit that referenced this pull request Jan 18, 2024
@yoosefap @dg
Extractor: supports PHP-Parser 5.0 (#150)
3eacc03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yoosefap @dg @JanTvrdik