Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ClassType: Added class constants #25

Merged
merged 1 commit into from Jun 8, 2017
Merged

ClassType: Added class constants #25

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
1 change: 1 addition & 0 deletions src/PhpGenerator/Factory.php
View file
Open in desktop
Expand Up @@ -46,6 +46,7 @@ public function fromClassReflection(\ReflectionClass $from): ClassType
}
}
$class->setMethods($methods);
$class->setConstants($from->getConstants());
return $class;
}

Expand Down
6 changes: 6 additions & 0 deletions tests/PhpGenerator/ClassType.from.expect
View file
Open in desktop
Expand Up @@ -64,3 +64,9 @@ class Class3
public $prop1;

}

class Class4
{
const THE_CONSTANT = 9;

}
9 changes: 8 additions & 1 deletion tests/PhpGenerator/ClassType.from.php71.expect
View file
Open in desktop
Expand Up @@ -15,4 +15,11 @@ class ClassA
{
}

}
}

class ClassB
{
const THE_PRIVATE_CONSTANT = 9;
const THE_PUBLIC_CONSTANT = 9;

}
7 changes: 7 additions & 0 deletions tests/PhpGenerator/ClassType.from.php71.phpt
View file
Open in desktop
Expand Up @@ -23,7 +23,14 @@ class ClassA
function func3(): void {}
}

class ClassB
{
private const THE_PRIVATE_CONSTANT = 9;
public const THE_PUBLIC_CONSTANT = 9;
}


$res[] = ClassType::from(ClassA::class);
$res[] = ClassType::from(ClassB::class);

Assert::matchFile(__DIR__ . '/ClassType.from.php71.expect', implode("\n", $res));
6 changes: 6 additions & 0 deletions tests/PhpGenerator/ClassType.from.phpt
View file
Open in desktop
Expand Up @@ -69,12 +69,18 @@ class Class3
public $prop1;
}

class Class4
{
const THE_CONSTANT = 9;
}

$res[] = ClassType::from(Interface1::class);
$res[] = ClassType::from(Interface2::class);
$res[] = ClassType::from(Class1::class);
$res[] = ClassType::from(new Class2);
$obj = new Class3;
$obj->prop2 = 1;
$res[] = (new Factory)->fromClassReflection(new \ReflectionObject($obj));
$res[] = ClassType::from(Class4::class);

Assert::matchFile(__DIR__ . '/ClassType.from.expect', implode("\n", $res));