-
-
Notifications
You must be signed in to change notification settings - Fork 134
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add failing test for array #51
Conversation
I can't see it. |
@dg what can't you see? (the test failure is not good enough for you?) I was not able to make a good fix for it :/. |
The current behavior is intentional. See php-generator/src/PhpGenerator/Dumper.php Line 102 in fd5e55c
Maybe there should be an option to disable this? |
Ok I get it. But it's not a bug, just a cosmetic thing because |
@dg absolutely. But this is also assuming PHP behaves like that, which is weird. And I think all weird stuff should not be considered as "this is good". Of course, it's also extremely disturbing for people that will use generated classes, that's mostly why I'm suggesting to support this. An option is probably the better idea, yes :). |
I would not call it a weird, it is a documented standard behavior that I like to use, for example in |
Hello, I found this bug :(.