Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Factory: fix method bodies import [Closes #61] #62

Merged
merged 2 commits into from Jun 5, 2020

Conversation

djaf77
Copy link
Contributor

@djaf77 djaf77 commented Jun 5, 2020

  • bug fix? yes [Closes #61]
  • BC break? no

fix method bodies import:
We collect all Name Nodes from $method->stmts, their resolved FQN and position in file.
Then we replace them in body string by positions with offset correction (because we change string length)
Test cases was changed too.

@dg
Copy link
Member

@dg dg commented Jun 5, 2020

Great, thanks!

@dg dg merged commit ec4299c into nette:master Jun 5, 2020
10 checks passed
dg pushed a commit that referenced this issue Jun 5, 2020
Co-authored-by: Anton Zolotilin <a.zolotilin@superjob.ru>
dg pushed a commit that referenced this issue Jun 19, 2020
Co-authored-by: Anton Zolotilin <a.zolotilin@superjob.ru>
dg pushed a commit that referenced this issue Jun 19, 2020
Co-authored-by: Anton Zolotilin <a.zolotilin@superjob.ru>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants