Skip to content

Fix simplifyName with relative path#94

Closed
jderusse wants to merge 1 commit intonette:masterfrom
jderusse:relative-short
Closed

Fix simplifyName with relative path#94
jderusse wants to merge 1 commit intonette:masterfrom
jderusse:relative-short

Conversation

@jderusse
Copy link
Copy Markdown

@jderusse jderusse commented Oct 15, 2021

  • bug fix
  • BC break? no
  • doc PR: -

This PR fixes a case where simplifyName uses the Relative path instead of ShortName

$namespace = new PhpNamespace('Foo\Bar');
$namespace->addUse('Foo\Bar\Baz\Qux');
echo $namespace->simplifyName('Foo\Bar\Baz\Qux'));

outputs Baz\Qux, instead of 'Qux';

@jderusse jderusse mentioned this pull request Oct 15, 2021
Merged
dg added a commit that referenced this pull request Oct 15, 2021
@dg
PhpNamespace::simplifyName() fixed relative path evaluation [Closes #94]
b8375ac
@dg dg force-pushed the master branch 2 times, most recently from 126d19e to b384276 Compare October 15, 2021 10:29
@dg
Copy link
Copy Markdown
Member

dg commented Oct 15, 2021

Fixed

@dg dg closed this Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@jderusse @dg