Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strings: Fix boolean return of Normalizer. #210

Merged
merged 1 commit into from Dec 16, 2019
Merged

Conversation

@janbarasek
Copy link
Contributor

janbarasek commented Dec 16, 2019

  • bug fix
  • BC break? yes

In case of Strings::normalize("... \xbee m\xc3\xa1\xc5\xa1 ..."); normalizer throw error, because \Normalizer::normalize can return false in case of invalid string.

Now normalized string will be used only in case of valid return. In other cases keep original.

Snímek obrazovky 2019-12-16 v 14 31 24

Thanks.

@dg

This comment has been minimized.

Copy link
Member

dg commented Dec 16, 2019

Thanks

@dg dg merged commit 175b0a8 into nette:master Dec 16, 2019
1 check passed
1 check passed
continuous-integration/travis-ci/pr The Travis CI build passed
Details
dg added a commit that referenced this pull request Dec 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
2 participants
You can’t perform that action at this time.