Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use quiche API for trace_id once it is exposed #12

Closed
normanmaurer opened this issue Nov 13, 2020 · 7 comments · Fixed by #146
Closed

Use quiche API for trace_id once it is exposed #12

normanmaurer opened this issue Nov 13, 2020 · 7 comments · Fixed by #146
Milestone
0.0.4.Final

Comments

@normanmaurer
Copy link
Member

See cloudflare/quiche#713
@normanmaurer
Copy link
Member Author

cloudflare/quiche#724

@vasantteja
Copy link

They already pushed the changes at cloudflare side can I work on this. Is there any sample of code which I can use as reference for my implementation. I have some free time over this weekend and I can spend on this one. Please don't mind.

@normanmaurer
Copy link
Member Author

Yes sure 👌

@normanmaurer
Copy link
Member Author

that said its only present in master atm... so no release yet to pick up. That said we can do the preparation now

@vasantteja
Copy link

@normanmaurer I spent a considerable time in understanding the changes that needs to done. Here is my understanding. We need to make netty c code to get trace id and expose it either in nativejndimethods or quiche Java code where we can pick up this trace id and use it everywhere. Please let me know if I got it right.

@normanmaurer
Copy link
Member Author

yes... it would be exposed in Quiche.

@vasantteja
Copy link

@normanmaurer Is it merged to the master branch?

normanmaurer added a commit that referenced this issue Jan 25, 2021
@normanmaurer
Make use of quiche_conn_trace_id(....)
9381973 
Motivation:

We should directly use quiche_conn_trace_id now that it is exposed.

Modifications:

Remove our custom implementation and just use the C API of quiche

Result:

Fixes #12
@normanmaurer normanmaurer added this to the 0.0.4.Final milestone Jan 25, 2021
normanmaurer added a commit that referenced this issue Jan 25, 2021
@normanmaurer
Make use of quiche_conn_trace_id(....)
c259fcc 
Motivation:

We should directly use quiche_conn_trace_id now that it is exposed.

Modifications:

Remove our custom implementation and just use the C API of quiche

Result:

Fixes #12
@normanmaurer normanmaurer mentioned this issue Jan 25, 2021
Merged
normanmaurer added a commit that referenced this issue Jan 25, 2021
@normanmaurer
Make use of quiche_conn_trace_id(....) (#146)
3d17d20 
Motivation:

We should directly use quiche_conn_trace_id now that it is exposed.

Modifications:

Remove our custom implementation and just use the C API of quiche

Result:

Fixes #12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
0.0.4.Final
Development

Successfully merging a pull request may close this issue.

Make use of quiche_conn_trace_id(....) netty/netty-incubator-codec-quic
2 participants
@normanmaurer @vasantteja