Getting protocol for session #1
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -1309,6 +1309,15 @@ TCN_IMPLEMENT_CALL(jstring, SSL, getCipherForSSL)(TCN_STDARGS, | |||
| return AJP_TO_JSTRING(SSL_get_cipher(J2P(ssl, SSL*))); | |||
| } | |||
|
|
|||
| // Read which protocol was negotiated for the given SSL *. | |||
| TCN_IMPLEMENT_CALL(jstring, SSL, getProtocolForSSL)(TCN_STDARGS, | |||
There was a problem hiding this comment.
Please call it getVersion as we usually use the same method names for java and c.
|
@fondemen can you please adjust the commit message to match our template: |
TLSv1.2 or SSLv3) Motivation: It is possible to check what is the chosen cipher for an SSL session, which is properly reported in netty using the OpenSSL implementation for SSLSession. However, protocol is reported as unknown. If using the JDK implementation, it is correctly reported such as as SSLv3. Knowing the session protocol can help in managing security properly, e.g. for accepting SSLv3 or TLSv1 in some parts of an application for compatibility, and allowing only TLSv1.1 or TLSv1.2 for more secured parts, such as user authentication. Modifications: Just adding a new native operation to SSL to quary protocol of an existing session thanks to its id. Result: It will be possible to implement getProtocol for the OpenSslEngine.getSession().getProtocol() so that it has same behavior as JDK implementation.
|
Corrections made to match your expectations. |
| @@ -1309,6 +1309,15 @@ TCN_IMPLEMENT_CALL(jstring, SSL, getCipherForSSL)(TCN_STDARGS, | |||
| return AJP_TO_JSTRING(SSL_get_cipher(J2P(ssl, SSL*))); | |||
| } | |||
|
|
|||
| // Read which protocol was negotiated for the given SSL *. | |||
| TCN_IMPLEMENT_CALL(jstring, SSL, getVersionForSSL)(TCN_STDARGS, | |||
|
@fondemen also please squash commits into 1 |
TLSv1.2 or SSLv3) Motivation: It is possible to check what is the chosen cipher for an SSL session, which is properly reported in netty using the OpenSSL implementation for SSLSession. However, protocol is reported as unknown. If using the JDK implementation, it is correctly reported such as as SSLv3. Knowing the session protocol can help in managing security properly, e.g. for accepting SSLv3 or TLSv1 in some parts of an application for compatibility, and allowing only TLSv1.1 or TLSv1.2 for more secured parts, such as user authentication. Modifications: Just adding a new native operation to SSL to quary protocol of an existing session thanks to its id. Result: It will be possible to implement getProtocol for the OpenSslEngine.getSession().getProtocol() so that it has same behavior as JDK implementation.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This simple pach would make possible to know what protocol is in use for a session.
If pulled, onc could later change OpenSslEngine.getSession() with:
SSLSession session = this.session;
if (session == null) {
this.session = session = new SSLSession() {
...
public String getProtocol() {
SSL.getProtocolForSSL(ssl);
}
instead of the current code