Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow ChunkedInput to provide the progress information #2741

Closed
trustin opened this issue Aug 5, 2014 · 0 comments
Closed

Allow ChunkedInput to provide the progress information #2741

trustin opened this issue Aug 5, 2014 · 0 comments
Assignees
@trustin
Labels
feature
Milestone
4.1.0.Beta2

Comments

@trustin
Copy link
Member

trustin commented Aug 5, 2014

Related issue: #2151

There is no way for ChunkedWriteHandler to know the progress of the transfer of a ChannelInput. Therefore, ChannelProgressiveFutureListener cannot get exact information about the progress of the transfer.

If you add a few methods that optionally provides the transfer progress to ChannelInput, it becomes possible for ChunkedWriteHandler to notify ChannelProgressiveFutureListeners.

If the input has no definite length, we can still use the progress so far, and consider the length of the input as 'undefined'.
@trustin trustin added this to the 4.1.0.Final milestone Aug 5, 2014
@trustin trustin added the feature label Aug 5, 2014
@plucury plucury mentioned this issue Aug 13, 2014
Closed
@trustin trustin modified the milestones: 4.1.0.Final, 4.1.0.Beta2 Aug 14, 2014
trustin pushed a commit that referenced this issue Aug 14, 2014
@plucury @trustin
Allow ChunkedInput to provide the progress of its transfer
ca29be5 
Related issue: #2741 and #2151

Motivation:

There is no way for ChunkedWriteHandler to know the progress of the
transfer of a ChannelInput. Therefore, ChannelProgressiveFutureListener
cannot get exact information about the progress of the transfer.

If you add a few methods that optionally provides the transfer progress
to ChannelInput, it becomes possible for ChunkedWriteHandler to notify
ChannelProgressiveFutureListeners.

If the input has no definite length, we can still use the progress so
far, and consider the length of the input as 'undefined'.

Modifications:

- Add ChunkedInput.progress() and ChunkedInput.length()
- Modify ChunkedWriteHandler to use progress() and length() to notify
  the transfer progress

Result:

ChunkedWriteHandler now notifies ChannelProgressiveFutureListener.
@trustin trustin closed this as completed Aug 14, 2014
trustin pushed a commit that referenced this issue Aug 14, 2014
@plucury @trustin
Allow ChunkedInput to provide the progress of its transfer
a241648 
Related issue: #2741 and #2151

Motivation:

There is no way for ChunkedWriteHandler to know the progress of the
transfer of a ChannelInput. Therefore, ChannelProgressiveFutureListener
cannot get exact information about the progress of the transfer.

If you add a few methods that optionally provides the transfer progress
to ChannelInput, it becomes possible for ChunkedWriteHandler to notify
ChannelProgressiveFutureListeners.

If the input has no definite length, we can still use the progress so
far, and consider the length of the input as 'undefined'.

Modifications:

- Add ChunkedInput.progress() and ChunkedInput.length()
- Modify ChunkedWriteHandler to use progress() and length() to notify
  the transfer progress

Result:

ChunkedWriteHandler now notifies ChannelProgressiveFutureListener.
@trustin trustin self-assigned this Aug 14, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@trustin trustin

Labels
feature
Projects
None yet
Milestone
4.1.0.Beta2
Development

No branches or pull requests
1 participant
@trustin