Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix I/O error handling in lexer and parser #106

Closed
netvl opened this issue Oct 3, 2015 · 3 comments
Closed

Fix I/O error handling in lexer and parser #106

netvl opened this issue Oct 3, 2015 · 3 comments
Assignees
@netvl
Labels
absolutely required architecture bug

Comments

@netvl
Copy link
Owner

netvl commented Oct 3, 2015

Currently I/O errors are silently consumed and treated like EOF.

Unfortunately, proper solution would require breaking change in xml::reader::Error.
@netvl netvl self-assigned this Oct 3, 2015
RGafiyatullin added a commit to RGafiyatullin/xml-rs that referenced this issue Oct 30, 2015
@RGafiyatullin
Issue netvl#106: Fix I/O error handling in lexer and parser
124192a 
    * moved `::util` to `::reader::util` -- there was nothing there but reading from the io::Read;
    * `impl Into<::reader::Error> for ::util::CharReadError`;
    * `::reader:lexer::Lexer::next_token( ... )` return type changed from `LexStep` to ::reader::Result<LexStep>;
    * exposed `EventReader<R>`'s souce as mut- and immut-reference: I need to feed my Buffer (:io::Read) somehow.
        ( Probably the better solution would be to pub-use PullParser in xml::reader, but it has too many private types in the API signatures )
RGafiyatullin added a commit to RGafiyatullin/xml-rs that referenced this issue Oct 30, 2015
@RGafiyatullin
(INCOMPLETE) Issue netvl#106: Fix I/O error handling in lexer and parser
909f34c 
    * moved `::util` to `::reader::util` -- there was nothing there but reading from the io::Read;
    * `impl Into<::reader::Error> for ::util::CharReadError`;
    * `::reader:lexer::Lexer::next_token( ... )` return type changed from `LexStep` to ::reader::Result<LexStep>;
    * exposed `EventReader<R>`'s souce as mut- and immut-reference: I need to feed my Buffer (:io::Read) somehow.
        ( Probably the better solution would be to pub-use PullParser in xml::reader, but it has too many private types in the API signatures )
RGafiyatullin added a commit to RGafiyatullin/xml-rs that referenced this issue Oct 30, 2015
@RGafiyatullin
Issue netvl#106: Fix I/O error handling in lexer and parser
a36e61a 
    * moved `::util` to `::reader::util` -- there was nothing there but reading from the io::Read;
    * `impl Into<::reader::Error> for ::util::CharReadError`;
    * `::reader:lexer::Lexer::next_token( ... )` return type changed from `LexStep` to ::reader::Result<LexStep>;
    * exposed `EventReader<R>`'s souce as mut- and immut-reference: I need to feed my Buffer (:io::Read) somehow.
        ( Probably the better solution would be to pub-use PullParser in xml::reader, but it has too many private types in the API signatures )
@RGafiyatullin
Copy link
Contributor

Ouch. GitHub appears to be so verbose...

@RGafiyatullin RGafiyatullin mentioned this issue Nov 2, 2015
Merged
netvl added a commit that referenced this issue Nov 15, 2015
@netvl
Merge pull request #109 from RGafiyatullin/gh-106-lex-errors-3
e273a02 
Issue #106: Fix I/O error handling in lexer and parser (attempt #3)
@jonas-schievink
Copy link

Can this be closed? Seems like #109 fixed this.

@netvl
Copy link
Owner Author

netvl commented Aug 11, 2016

Yep, it seems so.

@netvl netvl closed this as completed Aug 11, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@netvl netvl

Labels
absolutely required architecture bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@netvl @RGafiyatullin @jonas-schievink