Issue #106: Fix I/O error handling in lexer and parser (attempt #3) #109
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
New ret type: `reader::Result< Option<Token> >` Old ret type: `Option< reader::Result<Token> >`
| } | ||
| } | ||
|
|
||
| impl From<::util::CharReadError> for Error { |
There was a problem hiding this comment.
It think it is better to add use util; than to add a global namespace qualifier everywhere. Or even use util::CharReadError.
|
Looks really good to me, thank you very much! I have no other objections. |
| use super::ErrorKind::*; | ||
| match self.kind { | ||
| UnexpectedEof => &"Unexpected EOF", | ||
| Utf8( ref reason ) => error_description( reason ), |
There was a problem hiding this comment.
This is a minor stylistic issue, but spaces inside parentheses is not idiomatic style in Rust programs. This applies for the enum declaration as well.
I should definitely check how rustfmt works, probably it makes sense to use it for xml-rs.
|
Thank you very much! Sorry for the delay, I was really busy these two weeks :( |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue #106: This time it should be okay.
The tests are passed.
The error is popped up to the very
EventReader::nextcall.The EventReader's source is accessible via
er.source()ander.source_mut().I'm still not sure whether it is convenient to dive into the cases of
reader::Errorthough...