feat: Move to RKD endpoint #1409
Conversation
Move rkdartist to new endpoint and sdo dataset
| OPTIONAL { ?uri schema:description ?schema_description . } | ||
| OPTIONAL { ?uri schema:description ?schema_description . } | ||
| OPTIONAL { ?uri schema:birthPlace ?birthPlace . | ||
| FILTER(langMatches(lang(?birthPlace),"en")) } |
There was a problem hiding this comment.
@RubenSchalk Is the en intentional? Shouldn’t we prefer Dutch information by default?
There was a problem hiding this comment.
schema:Description is indeed only available in English, but that one is isn’t filtered in the query.
The other fields, schema:description, :birthplace, and :deathPlace are filtered but available in Dutch too, so I switched to "nl".
| VALUES ?type { schema:Person schema:Organization } | ||
| ?uri ?name ?label . | ||
| VALUES ?name { schema:name schema:alternateName } | ||
|
|
||
| ?uri ?predicate ?label . | ||
| ?label <bif:contains> ?virtuosoQuery . |
There was a problem hiding this comment.
I’m not sure that we should search all fields. If you search for ‘Vincent Van Gogh’ you’ll find many not so relevant results that mention Van Gogh in their scopeNote. Should we only include schema:name and schema:alternateName?
There was a problem hiding this comment.
I was also wondering if we should keep this in. I will check with RKD
There was a problem hiding this comment.
I limited this for now to schema:name and schema:alternateName for parity with the old endpoint. If needed, we can revert that later.
|
🎉 This PR is included in version 9.11.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
|
🎉 This PR is included in version 5.4.0 🎉 The release is available on npm package (@latest dist-tag) Your semantic-release bot 📦🚀 |
Fix #1128
Fix #720