Use string_view instead of const string&. #1134
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
angriman
force-pushed
the
use-string-view
branch
from
f94e3c3
to
7bd245c
Compare
|
That makes sense (especially for the substring methods you refactored) - I think we can merge this PR as is. Will insert the refactoring of the remaining code base to the project plan. |
fabratu
approved these changes
Oct 6, 2023
PetholzA
pushed a commit
to PetholzA/networkit
that referenced
this pull request
Oct 23, 2023
Use string_view instead of const string&.
PetholzA
pushed a commit
to PetholzA/networkit
that referenced
this pull request
Oct 23, 2023
Use string_view instead of const string&.
PetholzA
pushed a commit
to PetholzA/networkit
that referenced
this pull request
Oct 23, 2023
Use string_view instead of const string&.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
std::string_viewis a non-owning read-only view of a string, and it helps to avoid unnecessary memory allocations [1]. I think we should start using it instead ofconst std::string&.[1] https://www.modernescpp.com/index.php/c-17-avoid-copying-with-std-string-view/