Skip to content

Conversation

khesoem
Copy link
Contributor

@khesoem khesoem commented Dec 3, 2021

Hi,

This PR fixes 4 violations of Sonar Rule 2142: '"InterruptedException" should not be ignored'. This is done without introducing any new violations of Sonar rules.

The patch was generated automatically with the tool Sorald. For details on the fix applied here, please see Sorald's documentation on rule 2142.

P.S.: Note that this PR is not created/submitted by a bot. If you have any feedback, please leave them as comments.

@stevehu stevehu merged commit 911091a into networknt:master Dec 4, 2021
@stevehu
Copy link
Contributor

stevehu commented Dec 4, 2021

@khaes-kth Thanks a lot for your help.

@khesoem
Copy link
Contributor Author

khesoem commented Dec 4, 2021

Hi @stevehu

Thanks a lot for considering this PR and merging it.

Sorald (the tool that made this patch) is a part of a research project on automatic program repair.

We would be very happy to hear from you regarding any of the following topics:
1- The PR description: Was it explanatory enough? Did it have appropriate length? Did you prefer it to include some other information? ...?
2- The changed code: Did it have an appropriate style? ...?

We would also appreciate any other comment that you think it can help us to make Sorald a better tool.

Best,

@stevehu
Copy link
Contributor

stevehu commented Dec 4, 2021

@khaes-kth This is a very good tool and it would help a lot of open-source projects. The PR looks pretty good and easy to understand with a detailed description. I like the reference links if users want to explore the extra details.

Regarding the coding style, I found the first file has some indentation issues with some extra spaces. Other than that, looks good.

Again, thanks a lot for your help.

@khesoem
Copy link
Contributor Author

khesoem commented Dec 4, 2021

Thanks again for your encouraging comment.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants