Remote extra docs from pyproject and fix dependencies and prep for 1.4.1 #95
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Code changes look fine but I don't see any CI result for ReadTheDocs. Do we not have it enabled yet on this repo? |
|
@glennmatthews I'll have to check, not sure if it's automatically building the doc when we are pushing some changes to main |
glennmatthews
approved these changes
Jan 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #94
After looking more closely at the
pyproject.tomlit felt like the extra[docs]wasn't required so I removed it and I moved back all docs dependencies todev-dependencies. Some of them were already in there anyway.Also in a matter of time, I increased the package version to 1.4.1