Skip to content

Fix typing #58

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Apr 25, 2022
Merged

Fix typing #58

merged 1 commit into from
Apr 25, 2022

Conversation

pszulczewski
Copy link
Collaborator

@pszulczewski pszulczewski commented Apr 23, 2022 •
edited
Loading

Minor fix to typing.
Reason: All evaluate() methods should have the same typing.

lvrfrc87
lvrfrc87 approved these changes Apr 25, 2022
View reviewed changes
Copy link
Collaborator

@lvrfrc87 lvrfrc87 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for spotting that!

@lvrfrc87 lvrfrc87 merged commit 00ed93f into develop Apr 25, 2022
@chadell chadell deleted the fix_typing branch September 1, 2022 10:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lvrfrc87 lvrfrc87 lvrfrc87 approved these changes

@chadell chadell Awaiting requested review from chadell

@scetron scetron Awaiting requested review from scetron scetron is a code owner

@pke11y pke11y Awaiting requested review from pke11y

@grelleum grelleum Awaiting requested review from grelleum

@jeffkala jeffkala Awaiting requested review from jeffkala jeffkala is a code owner

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pszulczewski @lvrfrc87