Issue 92 #98

pszulczewski · 2023-04-18T14:48:18Z

Best review commit-by-commit, as it has been implemented in 3 steps:

add baseline test, without code modification yet
refactor to simplify
implement issue jdiff should support multiple ref key anchoring #92

lvrfrc87

I remember discussing about this long time ago! Good to have implemented! Great work!

* Update readme to start with use cases (#84) * Update readme to start with use cases * Apply suggestions from code review Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> * Update README.md Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> * Doc update (#87) * Fix operator checks to follow other check_type logic. (#85) * Fix operator checks to follow other check_type logic. * Add new release 0.0.2 Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> * Implement `ge` and `le` operator type (#89) * Release 0.0.2 (#88) * Update readme to start with use cases (#84) * Update readme to start with use cases * Apply suggestions from code review Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> * Update README.md Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> * Doc update (#87) * Fix operator checks to follow other check_type logic. (#85) * Fix operator checks to follow other check_type logic. * Add new release 0.0.2 Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> Co-authored-by: Christian Adell <christian.adell@networktocode.com> Co-authored-by: Ken Celenza <ken@celenza.org> Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> * add operator ge and le * fix validate tests Co-authored-by: Christian Adell <christian.adell@networktocode.com> Co-authored-by: Ken Celenza <ken@celenza.org> Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> * Fix parameter_match check, to support non-normalized data (#90) * Fix parameter_match check, to support non-normalized data * Add test * Update tests. * remove test print Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> * Update mypy * Bugfix to data normalization * Fix ref_key parsing * Update docs * Issue 92 (#98) * Base-line tests for future refactor. * Refactor to simplify code. * Implement issue #92 * Bump certifi from 2022.9.24 to 2022.12.7 (#95) Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.9.24 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2022.09.24...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Christian Adell <christian.adell@networktocode.com> Co-authored-by: Ken Celenza <ken@celenza.org> Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>

* Update readme to start with use cases (#84) * Update readme to start with use cases * Apply suggestions from code review Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> * Update README.md Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> * Doc update (#87) * Fix operator checks to follow other check_type logic. (#85) * Fix operator checks to follow other check_type logic. * Add new release 0.0.2 Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> * Implement `ge` and `le` operator type (#89) * Release 0.0.2 (#88) * Update readme to start with use cases (#84) * Update readme to start with use cases * Apply suggestions from code review Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> * Update README.md Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> * Doc update (#87) * Fix operator checks to follow other check_type logic. (#85) * Fix operator checks to follow other check_type logic. * Add new release 0.0.2 Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> Co-authored-by: Christian Adell <christian.adell@networktocode.com> Co-authored-by: Ken Celenza <ken@celenza.org> Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> * add operator ge and le * fix validate tests Co-authored-by: Christian Adell <christian.adell@networktocode.com> Co-authored-by: Ken Celenza <ken@celenza.org> Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> * Fix parameter_match check, to support non-normalized data (#90) * Fix parameter_match check, to support non-normalized data * Add test * Update tests. * remove test print Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> * Update mypy * Bugfix to data normalization * Fix ref_key parsing * Update docs * Issue 92 (#98) * Base-line tests for future refactor. * Refactor to simplify code. * Implement issue #92 * Bump certifi from 2022.9.24 to 2022.12.7 (#95) Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.9.24 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2022.09.24...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update version and changelog * update poetry lock * Update changelog * Issue 94 & 91 (#100) * Baseline unittests * Fix issue #94 * Remove test print * Fix issue #91 * Relax deepdiff dependency. * Update pyproject.toml Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> * Update poetry.lock * Relase v0.0.4 --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Christian Adell <christian.adell@networktocode.com> Co-authored-by: Ken Celenza <ken@celenza.org> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> Co-authored-by: Federico87 <15066806+lvrfrc87@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Network to Code <federico.olivieri@networktocode.com> Co-authored-by: Leo Kirchner <leo.kirchner98@gmail.com> Co-authored-by: Leo Kirchner <Kircheneer@users.noreply.github.com>

* Update readme to start with use cases (#84) * Update readme to start with use cases * Apply suggestions from code review Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> * Update README.md Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> * Doc update (#87) * Fix operator checks to follow other check_type logic. (#85) * Fix operator checks to follow other check_type logic. * Add new release 0.0.2 Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> * Implement `ge` and `le` operator type (#89) * Release 0.0.2 (#88) * Update readme to start with use cases (#84) * Update readme to start with use cases * Apply suggestions from code review Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> * Update README.md Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> * Doc update (#87) * Fix operator checks to follow other check_type logic. (#85) * Fix operator checks to follow other check_type logic. * Add new release 0.0.2 Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> Co-authored-by: Christian Adell <christian.adell@networktocode.com> Co-authored-by: Ken Celenza <ken@celenza.org> Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> * add operator ge and le * fix validate tests Co-authored-by: Christian Adell <christian.adell@networktocode.com> Co-authored-by: Ken Celenza <ken@celenza.org> Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> * Fix parameter_match check, to support non-normalized data (#90) * Fix parameter_match check, to support non-normalized data * Add test * Update tests. * remove test print Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> * Update mypy * Bugfix to data normalization * Fix ref_key parsing * Update docs * Issue 92 (#98) * Base-line tests for future refactor. * Refactor to simplify code. * Implement issue #92 * Bump certifi from 2022.9.24 to 2022.12.7 (#95) Bumps [certifi](https://github.com/certifi/python-certifi) from 2022.9.24 to 2022.12.7. - [Release notes](https://github.com/certifi/python-certifi/releases) - [Commits](certifi/python-certifi@2022.09.24...2022.12.07) --- updated-dependencies: - dependency-name: certifi dependency-type: indirect ... Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> * Update version and changelog * update poetry lock * Update changelog * Issue 94 & 91 (#100) * Baseline unittests * Fix issue #94 * Remove test print * Fix issue #91 * Relax deepdiff dependency. * Update pyproject.toml Co-authored-by: Patryk Szulczewski <patryk@szulczewski.eu> * Update poetry.lock * Relase v0.0.4 * Release v0.0.4 (#105) --------- Signed-off-by: dependabot[bot] <support@github.com> Co-authored-by: Christian Adell <christian.adell@networktocode.com> Co-authored-by: Ken Celenza <ken@celenza.org> Co-authored-by: Stephen Corry <stephen.corry@networktocode.com> Co-authored-by: Patryk Szulczewski <patryk.szulczewski@networktocode.com> Co-authored-by: Federico87 <15066806+lvrfrc87@users.noreply.github.com> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Network to Code <federico.olivieri@networktocode.com> Co-authored-by: Leo Kirchner <leo.kirchner98@gmail.com> Co-authored-by: Leo Kirchner <Kircheneer@users.noreply.github.com>

pszulczewski force-pushed the issue-92 branch from a6ce888 to a5061c0 Compare April 18, 2023 16:33

pszulczewski mentioned this pull request Apr 18, 2023

Bugfix to ref_key and data normalization. #96

Merged

pszulczewski force-pushed the issue-92 branch 2 times, most recently from 2c66b66 to 3687c8e Compare April 19, 2023 22:01

pszulczewski added 2 commits April 20, 2023 00:16

Base-line tests for future refactor.

7165e74

Refactor to simplify code.

4aafeeb

pszulczewski force-pushed the issue-92 branch 3 times, most recently from df7c34b to ff04f44 Compare April 19, 2023 22:21

pszulczewski marked this pull request as ready for review April 19, 2023 22:28

pszulczewski requested review from chadell, lvrfrc87, scetron and jeffkala as code owners April 19, 2023 22:28

pszulczewski linked an issue Apr 19, 2023 that may be closed by this pull request

jdiff should support multiple ref key anchoring #92

Closed

Implement issue #92

c8b784a

pszulczewski force-pushed the issue-92 branch from ff04f44 to c8b784a Compare April 19, 2023 22:49

lvrfrc87 approved these changes Apr 20, 2023

View reviewed changes

lvrfrc87 merged commit b1af665 into develop Apr 20, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

Issue 92 #98

Issue 92 #98

Uh oh!

pszulczewski commented Apr 18, 2023 •

edited

Loading

Uh oh!

lvrfrc87 left a comment

Uh oh!

Uh oh!

Issue 92 #98

Issue 92 #98

Uh oh!

Conversation

pszulczewski commented Apr 18, 2023 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

lvrfrc87 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

pszulczewski commented Apr 18, 2023 •

edited

Loading