MAINT: Add subgraph_view and reverse_view to nx namespace directly through graphviews #6689
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dschult
approved these changes
May 15, 2023
There was a problem hiding this comment.
I don't know any reason that these should not be imported directly into the base namespace from nx.graphviews. And I'm fairly sure they were imported via the functions.py due to the focus on the functions module already including an outright code copy of reverse_view.
I like this approach better.
Alex-Markham
pushed a commit
to Alex-Markham/networkx
that referenced
this pull request
Oct 13, 2023
…rough graphviews (networkx#6689) Add subgraph_view and reverse_view to nx namespace directly
dschult
pushed a commit
to BrunoBaldissera/networkx
that referenced
this pull request
Oct 23, 2023
…rough graphviews (networkx#6689) Add subgraph_view and reverse_view to nx namespace directly
cvanelteren
pushed a commit
to cvanelteren/networkx
that referenced
this pull request
Apr 22, 2024
…rough graphviews (networkx#6689) Add subgraph_view and reverse_view to nx namespace directly
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently
subgraph_viewandreverse_vieware available in the globalnxnamespace but they are exposed via a redirect infunctions.py. This was added in #3627 and I'm not a 100% sure why it is done this way.Also made changes to some other places where
subgraph_viewandreverse_viewwhere being imported vianetworkx.graphviewsand not via thenxnamespace.