-
Notifications
You must be signed in to change notification settings - Fork 176
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TextGeneration] Fix llama tokenizer #1635
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bfineran
approved these changes
Mar 14, 2024
mgoin
reviewed
Mar 14, 2024
src/deepsparse/transformers/pipelines/text_generation/prep_for_generation.py
Show resolved
Hide resolved
src/deepsparse/transformers/pipelines/text_generation/process_outputs.py
Show resolved
Hide resolved
mgoin
approved these changes
Mar 14, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for answering my questions, nice implementation
dhuangnm
pushed a commit
that referenced
this pull request
Mar 14, 2024
* add llama tokenizer fix * fix generated string * only run for streaming * add TODO --------- Co-authored-by: Dipika Sikka <dipikasikka1@gmail.coom>
dbogunowicz
reviewed
Mar 15, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A test would be nice to have, but I guess the priority is to land this asap.
src/deepsparse/transformers/pipelines/text_generation/process_outputs.py
Show resolved
Hide resolved
dhuangnm
added a commit
that referenced
this pull request
Mar 18, 2024
* [TextGeneration] Fix llama tokenizer (#1635) * add llama tokenizer fix * fix generated string * only run for streaming * add TODO --------- Co-authored-by: Dipika Sikka <dipikasikka1@gmail.coom> * Retire `flaky` in favour of `pytest-rerunfailures` (#1628) * pick up another fix and bump up version to 1.7.1 --------- Co-authored-by: Dipika Sikka <dipikasikka1@gmail.com> Co-authored-by: Dipika Sikka <dipikasikka1@gmail.coom> Co-authored-by: dbogunowicz <97082108+dbogunowicz@users.noreply.github.com> Co-authored-by: dhuang <dhuang@MacBook-Pro-2.local>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tested code:
Output: