Complete nm-vllm-production-monitoring chart #11
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lm-charts into add-grafana-configuration
DaltheCow
commented
May 2, 2024
DaltheCow
commented
May 9, 2024
Comment on lines
4
to
15
| - name: grafana | ||
| repository: https://grafana.github.io/helm-charts | ||
| version: 7.3.9 | ||
| - name: nm-vllm | ||
| repository: https://helm.neuralmagic.com | ||
| version: 0.1.1 | ||
| version: 0.1.2 | ||
| - name: nm-vllm-grafana-dashboards | ||
| version: 1.0.0 | ||
| repository: https://helm.neuralmagic.com | ||
| - name: prometheus | ||
| repository: https://prometheus-community.github.io/helm-charts | ||
| version: 25.12.0 |
There was a problem hiding this comment.
Just to confirm, we didn't intend to make the grafana and prometheus charts conditionally configurable via the enabled flag here did we? I know we talked about it but it seemed like maybe that was something that could be done in the future
DaltheCow
commented
May 9, 2024
charts/nm-vllm-production-monitoring/templates/config-map-datasources.yaml
Show resolved
Hide resolved
tdg5
reviewed
May 9, 2024
Comment on lines
30
to
31
| evaluation_interval: 30s | ||
| scrape_interval: 10s |
There was a problem hiding this comment.
During exploration, it turned out having values like these was important to getting the dashboard to work right
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.