Make grafana dashboards chart able to take grafana values #12
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tdg5
force-pushed
the
grafana-dashboards-speaks-grafana
branch
2 times, most recently
from
10c04a3
to
1fd3dc0
Compare
DaltheCow
reviewed
May 8, 2024
| "default": "", | ||
| "description": "Label value used by Grafana's dashboards sidecar to identify config maps with dashboards that should be added to Grafana. Should match the value of the `sidecar.dashboards.labelValue` configuration in the Grafana chart.", | ||
| "type": "string" | ||
| "type": ["null", "string"] |
tdg5
force-pushed
the
grafana-dashboards-speaks-grafana
branch
from
81d48c1
to
1769451
Compare
DaltheCow
previously approved these changes
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@DaltheCow do you have an opinion on whether or not we should do this? I don't have to rename the variables, but it is a bit more consistent like this. It seems like the "taking values from grafana" part of things is a sensible thing to do.