New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix inputs to os.path.join in ONNX export #14

Merged

markurtz merged 2 commits into master from fix-onnx-export-patch-1

Jul 28, 2021

bfineran commented Jul 28, 2021

should be separate str-like arguments instead of List[str]


          fix inputs to os.path.join in ONNX export

43f6878

should be separate str-like arguments instead of `List[str]`

bfineran requested review from kevinaer, markurtz, a team and natuan and removed request for a team

July 28, 2021 17:42

markurtz approved these changes

View reviewed changes


          use Path().parent

markurtz merged commit 47c0565 into master

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet