Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Python 3.6 support #2421

Merged
merged 6 commits into from
Nov 23, 2021
Merged

Drop Python 3.6 support #2421

merged 6 commits into from
Nov 23, 2021

Conversation

asvetlov
Copy link
Contributor

No description provided.

@lgtm-com
Copy link

lgtm-com bot commented Nov 23, 2021

This pull request introduces 1 alert and fixes 2 when merging 8f33493 into ac65952 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Nov 23, 2021

This pull request introduces 1 alert and fixes 2 when merging 909048a into ac65952 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@lgtm-com
Copy link

lgtm-com bot commented Nov 23, 2021

This pull request introduces 1 alert and fixes 2 when merging dd130df into ac65952 - view on LGTM.com

new alerts:

  • 1 for Module is imported with 'import' and 'import from'

fixed alerts:

  • 1 for Unused import
  • 1 for Module is imported with 'import' and 'import from'

@codecov
Copy link

codecov bot commented Nov 23, 2021

Codecov Report

Merging #2421 (dd130df) into master (ac65952) will increase coverage by 0.05%.
The diff coverage is 90.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2421      +/-   ##
==========================================
+ Coverage   74.98%   75.03%   +0.05%     
==========================================
  Files          63       63              
  Lines       10752    10698      -54     
  Branches     1660     1903     +243     
==========================================
- Hits         8062     8027      -35     
+ Misses       2417     2375      -42     
- Partials      273      296      +23     
Impacted Files Coverage Δ
neuro-cli/src/neuro_cli/utils.py 81.49% <ø> (-0.06%) ⬇️
neuro-sdk/src/neuro_sdk/utils.py 97.36% <ø> (+1.57%) ⬆️
neuro-cli/src/neuro_cli/asyncio_utils.py 63.28% <71.42%> (-4.85%) ⬇️
neuro-cli/src/neuro_cli/ael.py 16.58% <100.00%> (ø)
...euro-cli/src/neuro_cli/docker_credential_helper.py 85.18% <100.00%> (ø)
neuro-cli/src/neuro_cli/job.py 42.91% <100.00%> (+0.11%) ⬆️
neuro-cli/src/neuro_cli/main.py 50.00% <100.00%> (-0.95%) ⬇️
neuro-sdk/src/neuro_sdk/_bucket_base.py 65.44% <100.00%> (-0.75%) ⬇️
neuro-sdk/src/neuro_sdk/buckets.py 56.72% <100.00%> (-0.38%) ⬇️
neuro-sdk/src/neuro_sdk/core.py 87.50% <100.00%> (-0.09%) ⬇️
... and 16 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ac65952...dd130df. Read the comment docs.

@asvetlov asvetlov merged commit 83f7c0b into master Nov 23, 2021
@asvetlov asvetlov deleted the drop-3.6 branch November 23, 2021 17:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant