Continuous value component refactor #224
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The continuous values component now displays possible transformation heuristics it gets from the store in a dropdown. The user can select the correct transformation heuristic
- the component displays the heuristic selected for the active category in the store - component displays a preview of the transformed values from the store - the selected heuristic is emitted to the store with the active Category
This functionality is now implemented in the more generic continuous-values-component
|
@jarmoza: we're now coming to the part of the refactor where the end to end tests are actually breaking 🦀 - as they should. So to make sure that the component tests are passing, we'll have to look at the tests directly. Might be worth eventually to configure a separate action for component and e2e tests to run, so we can distinguish what is breaking edit: you can't actually see the component tests passing, because the test run stops before that. That we should probably address a bit sooner edit2: tracking this now in #225 |
surchs
changed the base branch from
master
to
dev_components_talk_to_store_directly
merging changes from the dev branch here so we can see the component tests pass
|
Merging now with these comments addressed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR does three things:
annot-age-valuescomponentCloses #208