Refactored annot-columns component so it's ready for the store #249
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rmanaem
added
the
maint:refactor
surchs
reviewed
Dec 9, 2022
There was a problem hiding this comment.
Thanks @rmanaem! Really nice, clear, and to the point 🎉 . I think this is good to go, but I added some suggestions you can look at. The only really relevant one is whether you can reuse one of the mutations we had already thought of (and have listed on the miro board). Since we're already at it, might save a little bit of refactoring later ...
- Modified the component alias to annotColumns - Added activeCategory as input to the removeColumn mutation
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #248